Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority extensions #162

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Priority extensions #162

wants to merge 11 commits into from

Conversation

halostatue
Copy link
Member

@halostatue halostatue commented Jan 7, 2022

This is very much a work in progress.


This change is Reviewable

- Added extension priority map. This is an imperfect solution, and is
  not used by default with default configuration (column-based data).

  - We may want to consider a revised columnar format for a future
    version that has a bit more information than is present in the base
    file.

- Adding the sort priority and extension priority helped, but because
  the alphanumeric sort was first in `MIME::Type#priority_compare`, the
  results weren't as good as they should have been. We now sort by the
  sort priority values _first_ and the alphanumeric values _second_.

  - Stored sort priority was not respected because it depends on flags
    not kept in the base file. Added support for a binary file with this
    to ensure it is loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant